Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drop CircleCI #2412

Merged
merged 22 commits into from
Jun 30, 2020
Merged

tests: drop CircleCI #2412

merged 22 commits into from
Jun 30, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 29, 2020

What does this PR do?

Drop CircleCI as it is too slow and limited nb jobs in concurrency

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added feature Is an improvement or enhancement ci Continuous Integration labels Jun 29, 2020
@Borda Borda added this to the 0.8.x milestone Jun 29, 2020
@mergify mergify bot requested a review from a team June 29, 2020 08:20
@Borda Borda marked this pull request as ready for review June 29, 2020 11:19
@Borda Borda marked this pull request as draft June 29, 2020 11:58
@Borda Borda force-pushed the tests/drop-circleci branch from 2fb6b41 to 9a082a3 Compare June 29, 2020 12:26
@Borda Borda force-pushed the tests/drop-circleci branch from 40f3c19 to bef8eca Compare June 29, 2020 20:57
@Borda
Copy link
Member Author

Borda commented Jun 30, 2020

@Borda Borda force-pushed the tests/drop-circleci branch from 1629b72 to 344178c Compare June 30, 2020 07:10
@Borda
Copy link
Member Author

Borda commented Jun 30, 2020

@hadim mind have a look if you have any suggestion what am I doing wrong?

@Borda Borda force-pushed the tests/drop-circleci branch from e58cc58 to cfbe493 Compare June 30, 2020 07:42
@Borda Borda added the help wanted Open to be worked on label Jun 30, 2020
@Borda Borda force-pushed the tests/drop-circleci branch from 41151a1 to 6401859 Compare June 30, 2020 13:28
@Borda
Copy link
Member Author

Borda commented Jun 30, 2020

@tgaddair is horovod avalaible on any Conda channel?

@Borda Borda marked this pull request as ready for review June 30, 2020 14:35
@Borda Borda removed the help wanted Open to be worked on label Jun 30, 2020
@williamFalcon williamFalcon merged commit d4a02e3 into master Jun 30, 2020
@Borda Borda deleted the tests/drop-circleci branch June 30, 2020 14:59
@Borda Borda mentioned this pull request Jun 30, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants