Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading past checpoints #2405

Merged
merged 2 commits into from
Jun 28, 2020
Merged

fix loading past checpoints #2405

merged 2 commits into from
Jun 28, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 28, 2020

What does this PR do?

The issues was stored hparams_type whic was not callable but string in past...

Fixes #2334

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Jun 28, 2020
@mergify mergify bot requested a review from a team June 28, 2020 20:47
@williamFalcon williamFalcon merged commit 861a73b into master Jun 28, 2020
@Borda Borda added this to the 0.8.x milestone Jun 28, 2020
@Borda Borda deleted the bugfix/past-checkpoint branch June 28, 2020 21:26
@Borda
Copy link
Member Author

Borda commented Jun 28, 2020

Screenshot at 2020-06-28 23-47-41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightningModule.load_from_checkpoint not working with .ckpt from 0.7.6
2 participants