Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading model with kwargs #2387

Merged
merged 3 commits into from
Jun 27, 2020
Merged

fix loading model with kwargs #2387

merged 3 commits into from
Jun 27, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 27, 2020

What does this PR do?

Fix loading from checkpoint...

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working ci Continuous Integration labels Jun 27, 2020
@mergify mergify bot requested a review from a team June 27, 2020 16:49
@Borda Borda changed the title test fix loading model with kwargs Jun 27, 2020
@Borda Borda requested review from awaelchli and williamFalcon June 27, 2020 17:51
@Borda Borda added this to the 0.8.x milestone Jun 27, 2020
@williamFalcon williamFalcon merged commit 51711c2 into master Jun 27, 2020
@williamFalcon
Copy link
Contributor

nice!

@williamFalcon williamFalcon deleted the bugfix/hparams branch June 27, 2020 20:38
@nischal-sanil
Copy link

Does this pr solve these issues #2386 #2359 #2364 ?

@Borda
Copy link
Member Author

Borda commented Jun 28, 2020

@nischal-sanil even they are similar, but I guess it is not fix... Mind try the master and eventually share minimal examples to reproduce? :)

@nischal-sanil
Copy link

@Borda Sorry I had forgotten to add the steps to reproduce the error. I have updated my current issue #2386 to contain the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants