Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor training loop #2336

Merged
merged 8 commits into from
Jun 24, 2020
Merged

refactor training loop #2336

merged 8 commits into from
Jun 24, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Jun 23, 2020

compartmentalizes training loop to simplify refactoring

@mergify mergify bot requested a review from a team June 23, 2020 23:23
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #2336 into master will increase coverage by 0%.
The diff coverage is 95%.

@@          Coverage Diff           @@
##           master   #2336   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          70      70           
  Lines        5512    5531   +19     
======================================
+ Hits         4851    4871   +20     
+ Misses        661     660    -1     

@williamFalcon williamFalcon merged commit 598f514 into master Jun 24, 2020
@Borda Borda added the feature Is an improvement or enhancement label Jun 24, 2020
@Borda Borda deleted the eval branch June 24, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants