Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated Trainer proc_rank #2269

Merged
merged 2 commits into from
Jun 19, 2020
Merged

deprecated Trainer proc_rank #2269

merged 2 commits into from
Jun 19, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 19, 2020

What does this PR do?

Fixes #2267

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 0 High priority task labels Jun 19, 2020
@mergify mergify bot requested a review from a team June 19, 2020 12:11
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #2269 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2269   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          70      70           
  Lines        5486    5491    +5     
======================================
+ Hits         4814    4819    +5     
  Misses        672     672           

@Borda Borda force-pushed the deprecated/proc_rank branch from f99e893 to 45903ae Compare June 19, 2020 15:30
@Borda Borda added this to the 0.8.x milestone Jun 19, 2020
@Borda Borda added the ready PRs ready to be merged label Jun 19, 2020
@williamFalcon williamFalcon merged commit e0b7fed into master Jun 19, 2020
@Borda Borda deleted the deprecated/proc_rank branch June 19, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Trainer' object has no attribute 'proc_rank'
2 participants