Adds back the slow spawn ddp implementation that people want #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-08 21:36:29 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2115 +/- ##
======================================
- Coverage 86% 86% -0%
======================================
Files 75 75
Lines 4786 4791 +5
======================================
Hits 4129 4129
- Misses 657 662 +5 |
justusschock
pushed a commit
that referenced
this pull request
Jun 29, 2020
* training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * training batch clean up * adding spawn * adding spawn * adding spawn * adding spawn * adding spawn * adding spawn * adding spawn * adding spawn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the implementation with .spawn has many issues
This PR adds back this implementation under 'ddp_spawn' but keeps the much faster, script-based version 'ddp' as default.
FIxes #2116
Fixes #2104 (use ddp_spawn in the meantime)
Fixes #2092
Fixes #2086
Fixes #2085