Enable NeptuneLogger to work with distributed_backend=ddp #1753
+76
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pitercl! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-05-08 14:34:24 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 69 69
Lines 4158 4166 +8
======================================
+ Hits 3668 3675 +7
- Misses 490 491 +1 |
|
This pull request is now in conflict... :( |
|
Hi @Borda, thanks for the review. Since I'm conflicting with master, what is the workflow now? Should I rebase my branch onto master? Or maybe wait for more reviews before rebasing? (from what I see I need 3 approvals) |
|
Think you can rebase now =) |
pitercl
force-pushed
the
bugfix/1683-neptune-logger-ddp-fix
branch
from
a3d1fd4 to
9a501ff
Compare
pitercl
force-pushed
the
bugfix/1683-neptune-logger-ddp-fix
branch
from
9a501ff to
a880802
Compare
Borda
requested changes
May 9, 2020
|
@pitercl pls allow edit PR... |
Borda
approved these changes
May 10, 2020
|
just pls add a note to changelog :] |
Borda
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1683 (issue).
The main change in this PR is that Neptune experiment is created eagerly on NeptuneLogger instantiation. After it's created it can be retrieved in spawned Trainer process. This enables the logger to work in distrubuted trainings.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃