test pickling #1636
Merged
test pickling #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-04-27 12:47:28 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1636 +/- ##
======================================
Coverage 89% 89%
======================================
Files 71 71
Lines 4171 4174 +3
======================================
+ Hits 3696 3699 +3
Misses 475 475 |
Borda
pushed a commit
that referenced
this pull request
Apr 27, 2020
fix hparams issue cache cache cache cache ddp pickle ddp pickle ddp pickle ddp pickle ddp pickle ddp pickle ddp pickle ddp fix pep8
|
the tests should also cover unpickling to verify that everything is reloaded properly |
| @@ -57,6 +57,7 @@ def __init__(self, monitor: str = 'val_loss', min_delta: float = 0.0, patience: | |||
| self.min_delta = min_delta | |||
| self.wait = 0 | |||
| self.stopped_epoch = 0 | |||
| self.mode = mode | |||
|
|
|||
| mode_dict = { | |||
There was a problem hiding this comment.
don't like that this mode_dict is defined in two places now..
mind send followup PR? 🐰 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pickling seems to be a problem more frequently. Tests added to test the API for pickling.