Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diable val and test shuffling #1600

Merged
merged 8 commits into from
Apr 25, 2020
Merged

diable val and test shuffling #1600

merged 8 commits into from
Apr 25, 2020

Conversation

williamFalcon
Copy link
Contributor

Fixes part of #1551

@mergify mergify bot requested a review from a team April 24, 2020 19:37
@williamFalcon
Copy link
Contributor Author

Need to request .shuffle in the dataloader

@awaelchli
Copy link
Contributor

awaelchli commented Apr 24, 2020 •
edited
Loading

If shuffle is set to True, the DataLoader will set the RandomSampler, so as an alternative, we could check if isinstance(dataloader.sampler, RandomSampler).

https://github.com/pytorch/pytorch/blob/a13b5b0ae85ea6b9ba6038f99658a88039e23782/torch/utils/data/dataloader.py#L212

@williamFalcon williamFalcon reopened this Apr 24, 2020
@williamFalcon
Copy link
Contributor Author

@awaelchli ahhh there it is haha. good catch.

@Borda Borda added the bug Something isn't working label Apr 24, 2020
@williamFalcon williamFalcon added this to the 0.7.4 milestone Apr 25, 2020
@williamFalcon williamFalcon added feature Is an improvement or enhancement and removed bug Something isn't working labels Apr 25, 2020
@pep8speaks
Copy link

pep8speaks commented Apr 25, 2020 •
edited
Loading

Hello @williamFalcon! Thanks for updating this PR.

Line 202:111: E501 line too long (116 > 110 characters)

Comment last updated at 2020-04-25 20:26:44 UTC

@Borda Borda requested a review from awaelchli April 25, 2020 20:26
@Borda
Copy link
Member

Borda commented Apr 25, 2020

@williamFalcon check update

@williamFalcon williamFalcon merged commit b620d86 into master Apr 25, 2020
@Borda Borda deleted the shuffle branch April 25, 2020 21:16
@asrafulashiq asrafulashiq mentioned this pull request May 17, 2020
Merged
5 tasks
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.
4 participants
@williamFalcon @awaelchli @pep8speaks @Borda