Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes automatic parser bug #1585

Merged
merged 19 commits into from
Apr 24, 2020
Merged

Fixes automatic parser bug #1585

merged 19 commits into from
Apr 24, 2020

Conversation

williamFalcon
Copy link
Contributor

--gpus "1" sets 1 GPU (any index)
--gpus "1," sets the "1" GPU (gpu at index 0)
--gpus 2 sets 2 GPUs (any index)
--gpus "1," sets the "2" GPU (gpu at index 1)
--gpus "3,4" sets the "3,4" GPUs (gpu at index 3,4)

@mergify mergify bot requested a review from a team April 23, 2020 23:52
@pep8speaks
Copy link

pep8speaks commented Apr 24, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-24 00:30:25 UTC

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #1585 into master will decrease coverage by 0%.
The diff coverage is 54%.

@@          Coverage Diff           @@
##           master   #1585   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files          68      68           
  Lines        3956    3967   +11     
======================================
+ Hits         3501    3506    +5     
- Misses        455     461    +6     

@williamFalcon williamFalcon merged commit 890458f into master Apr 24, 2020
@williamFalcon williamFalcon deleted the parser branch April 24, 2020 01:08
@Borda Borda added the bug Something isn't working label Apr 24, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 24, 2020
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants