Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested metrics dictionaries now can be passed to the loggers #1582

Merged

Conversation

alexeykarnachev
Copy link
Contributor

@alexeykarnachev alexeykarnachev commented Apr 23, 2020

Before submitting

  • Was this discussed/approved via a Github issue?
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests? Only doctest updated.
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1507
Nested metrics dicts now can be passed to the logger.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@alexeykarnachev alexeykarnachev changed the title now func merge_dicts works with nested dictionaries [WIP] Nested metrics dictionaries now can be passed to the loggers Apr 23, 2020
@mergify mergify bot requested a review from a team April 23, 2020 20:28
@alexeykarnachev alexeykarnachev changed the title [WIP] Nested metrics dictionaries now can be passed to the loggers Nested metrics dictionaries now can be passed to the loggers Apr 23, 2020
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #1582 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1582   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          68      68           
  Lines        3954    3957    +3     
======================================
+ Hits         3496    3499    +3     
  Misses        458     458           

@williamFalcon williamFalcon merged commit edb8d7a into Lightning-AI:master Apr 23, 2020
@Borda Borda added the feature Is an improvement or enhancement label Apr 23, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 23, 2020
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After update from 0.5.x to 0.7.3 merge_dicts #1278 sometimes breaks training
3 participants