Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LightningTemplateModel #1577

Merged
merged 6 commits into from
May 2, 2020
Merged

Conversation

festeh
Copy link
Contributor

@festeh festeh commented Apr 23, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1546. Now it's possible to run Trainer.test() for LightningTemplateModel

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 23, 2020 17:21
@williamFalcon
Copy link
Contributor

this example is very old.
We really should just remove it or replace it with
https://colab.research.google.com/drive/1-_LKx4HwAxl5M6xPJmqAAu444LTDQoa3#scrollTo=8kaxQli2ahpR

Copy link
Contributor

@williamFalcon williamFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make the correct changes instead :)

@mergify mergify bot requested a review from a team April 23, 2020 17:25
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #1577 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1577   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          71      71           
  Lines        4175    4175           
======================================
  Hits         3692    3692           
  Misses        483     483           

@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2020

This pull request is now in conflict... :(

@Borda Borda added bug Something isn't working waiting on author Waiting on user action, correction, or update labels Apr 25, 2020
@festeh festeh force-pushed the fix_template branch 2 times, most recently from 3a4fb1a to 201f4f0 Compare April 29, 2020 18:09
@festeh
Copy link
Contributor Author

festeh commented Apr 29, 2020

I find it useful to have a simple example in the repository, sometimes it helps me to do some quick experiments. So I updated this module to look more like Colab version.

@festeh festeh requested review from williamFalcon and removed request for a team April 29, 2020 21:01
@mergify mergify bot requested a review from a team April 29, 2020 21:02
@williamFalcon williamFalcon merged commit 210cd65 into Lightning-AI:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting on author Waiting on user action, correction, or update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightningTemplateModel is broken
3 participants