-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix LightningTemplateModel #1577
Conversation
this example is very old. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make the correct changes instead :)
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
======================================
Coverage 88% 88%
======================================
Files 71 71
Lines 4175 4175
======================================
Hits 3692 3692
Misses 483 483 |
This pull request is now in conflict... :( |
3a4fb1a
to
201f4f0
Compare
I find it useful to have a simple example in the repository, sometimes it helps me to do some quick experiments. So I updated this module to look more like Colab version. |
Before submitting
What does this PR do?
Fixes #1546. Now it's possible to run
Trainer.test()
forLightningTemplateModel
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃