Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model_checkpoint to save all models #1359

Merged
merged 3 commits into from
Apr 5, 2020
Merged

model_checkpoint to save all models #1359

merged 3 commits into from
Apr 5, 2020

Conversation

williamFalcon
Copy link
Contributor

Finishes #1160

@williamFalcon williamFalcon mentioned this pull request Apr 3, 2020
Closed
5 tasks
@mergify mergify bot requested a review from a team April 3, 2020 13:28
@Borda Borda added the bug Something isn't working label Apr 3, 2020
@Borda Borda added this to the 0.7.2 milestone Apr 3, 2020
@williamFalcon
Copy link
Contributor Author

@jeremyjordan @MattPainter01 you guys wanted more changes to this? i’ll approve. when you guys are happy you already have my vote to merge.

@williamFalcon
Copy link
Contributor Author

false lol. can’t self approve

@Borda
Copy link
Member

Borda commented Apr 3, 2020 •
edited
Loading

false lol. can’t self approve

😆

jeremyjordan
jeremyjordan approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@jeremyjordan jeremyjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda self-assigned this Apr 4, 2020
Borda
Borda approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 just add note to chnagelog

@Borda Borda requested a review from a team April 5, 2020 07:17
@Borda Borda added the ready PRs ready to be merged label Apr 5, 2020
@Borda Borda removed the ready PRs ready to be merged label Apr 5, 2020
@Borda Borda requested a review from a team April 5, 2020 10:00
@Borda Borda requested a review from a team April 5, 2020 11:09
@Borda Borda merged commit f1e11d8 into master Apr 5, 2020
@Borda Borda deleted the jamesjjcondon-save_top_k=-1 branch April 5, 2020 13:56
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@williamFalcon @jamesjjcondon
@Borda @tullie
model_checkpoint to save all models (Lightning-AI#1359)
613536a 
* model_checkpoint to save all models

* changelog

* rise if

Co-authored-by: jamesjjcondon <[email protected]>
Co-authored-by: J. Borovec <[email protected]>
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyjordan jeremyjordan jeremyjordan approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

Assignees

@Borda Borda

Labels
bug Something isn't working
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.
5 participants
@williamFalcon @Borda @justusschock @jeremyjordan @jamesjjcondon