Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid changing the current cudnn.benchmark value #13154

Merged
merged 4 commits into from
May 31, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 25, 2022

What does this PR do?

Re-land of #12020
Fixes #12713

Does your PR introduce any breaking changes? If yes, please list them.

Benchmark now defaults to False, as it was in v1.5

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @justusschock @kaushikb11 @awaelchli @Borda @rohitgr7 @akihironitta

@carmocca carmocca added this to the 1.6.x milestone May 25, 2022
@carmocca carmocca self-assigned this May 25, 2022
@carmocca carmocca force-pushed the bugfix/revert-benchmark branch from f5d09c7 to 4b3e3fc Compare May 25, 2022 17:07
@carmocca carmocca changed the title Bugfix/revert benchmark Avoid changing the current cudnn.benchmark value May 25, 2022
@carmocca carmocca marked this pull request as ready for review May 25, 2022 17:09
@mergify mergify bot added the ready PRs ready to be merged label May 25, 2022
tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) May 31, 2022 18:42
Copy link
Contributor Author

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatekeeper

@carmocca carmocca merged commit 01ebb1f into master May 31, 2022
@carmocca carmocca deleted the bugfix/revert-benchmark branch May 31, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.6 is slower than v1.5
6 participants