-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid changing the current cudnn.benchmark value #13154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
force-pushed
the
bugfix/revert-benchmark
branch
from
May 25, 2022 17:07
f5d09c7
to
4b3e3fc
Compare
carmocca
changed the title
Bugfix/revert benchmark
Avoid changing the current cudnn.benchmark value
May 25, 2022
carmocca
requested review from
williamFalcon,
tchaton,
awaelchli,
SeanNaren,
Borda,
edenlightning,
justusschock,
kaushikb11 and
rohitgr7
as code owners
May 25, 2022 17:09
justusschock
approved these changes
May 25, 2022
ananthsub
approved these changes
May 25, 2022
akihironitta
approved these changes
May 25, 2022
Borda
approved these changes
May 27, 2022
awaelchli
approved these changes
May 30, 2022
carmocca
commented
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gatekeeper
carmocca
added a commit
that referenced
this pull request
May 31, 2022
carmocca
added a commit
that referenced
this pull request
May 31, 2022
lexierule
pushed a commit
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-land of #12020
Fixes #12713
Does your PR introduce any breaking changes? If yes, please list them.
Benchmark now defaults to
False
, as it was in v1.5Before submitting
PR review
cc @justusschock @kaushikb11 @awaelchli @Borda @rohitgr7 @akihironitta