Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trainer profiler typehint to use Profiler instead of the deprecated BaseProfiler #13084

Merged

Conversation

mads-oestergaard
Copy link
Contributor

@mads-oestergaard mads-oestergaard commented May 16, 2022

What does this PR do?

Fixes #13046

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mads-oestergaard
Copy link
Contributor Author

mads-oestergaard commented May 16, 2022

Does this PR qualify for a new line in the changelog?
And do I have to add labels to it?

@akihironitta akihironitta added bug Something isn't working trainer: argument labels May 16, 2022
@akihironitta akihironitta added this to the 1.6.x milestone May 16, 2022
@akihironitta akihironitta added the community This PR is from the community label May 16, 2022
@akihironitta akihironitta self-assigned this May 16, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Does this PR qualify for a new line in the changelog?

Yes, let's add a changelog entry :]

And do I have to add labels to it?

Done! Thanks for checking :)

@mads-oestergaard
Copy link
Contributor Author

mads-oestergaard commented May 16, 2022

Yes, let's add a changelog entry :]

Perfect! I've just pushed an update to the changelog :)

@mergify mergify bot added the ready PRs ready to be merged label May 16, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@akihironitta akihironitta enabled auto-merge (squash) May 22, 2022 07:39
@akihironitta akihironitta merged commit 11e289a into Lightning-AI:master May 23, 2022
carmocca added a commit that referenced this pull request May 24, 2022
…recated `BaseProfiler` (#13084)

* Fix trainer profiler typehint

* Remove unused import of deprecated BaseProfiler

* Update CHANGELOG.md

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca added a commit that referenced this pull request May 31, 2022
…recated `BaseProfiler` (#13084)

* Fix trainer profiler typehint

* Remove unused import of deprecated BaseProfiler

* Update CHANGELOG.md

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Jun 1, 2022
…recated `BaseProfiler` (#13084)

* Fix trainer profiler typehint

* Remove unused import of deprecated BaseProfiler

* Update CHANGELOG.md

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community ready PRs ready to be merged trainer: argument
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer profilers are typehinted with the deprecated BaseProfiler instead of Profiler
6 participants