-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trainer profiler typehint to use Profiler
instead of the deprecated BaseProfiler
#13084
Update trainer profiler typehint to use Profiler
instead of the deprecated BaseProfiler
#13084
Conversation
Does this PR qualify for a new line in the changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Does this PR qualify for a new line in the changelog?
Yes, let's add a changelog entry :]
And do I have to add labels to it?
Done! Thanks for checking :)
Perfect! I've just pushed an update to the changelog :) |
…recated `BaseProfiler` (#13084) * Fix trainer profiler typehint * Remove unused import of deprecated BaseProfiler * Update CHANGELOG.md Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
…recated `BaseProfiler` (#13084) * Fix trainer profiler typehint * Remove unused import of deprecated BaseProfiler * Update CHANGELOG.md Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
…recated `BaseProfiler` (#13084) * Fix trainer profiler typehint * Remove unused import of deprecated BaseProfiler * Update CHANGELOG.md Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
What does this PR do?
Fixes #13046
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃