Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all ddp params for hpu parallel strategy #13067

Merged
merged 11 commits into from
May 19, 2022
Merged

Enable all ddp params for hpu parallel strategy #13067

merged 11 commits into from
May 19, 2022

Conversation

jerome-habana
Copy link
Contributor

Signed-off-by: Jerome [email protected]

What does this PR do?

Expose all available ddp params to be used through hpu parallel strategy

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@jerome-habana jerome-habana marked this pull request as ready for review May 16, 2022 07:36
@kaushikb11 kaushikb11 added the accelerator: hpu (external) Habana Processing Unit label May 16, 2022
@jerome-habana
Address reviews
a59cd38 
Signed-off-by: Jerome <[email protected]>
@jerome-habana jerome-habana requested a review from kaushikb11 May 18, 2022 03:20
@mergify mergify bot added the ready PRs ready to be merged label May 18, 2022
carmocca
carmocca reviewed May 18, 2022
View reviewed changes
tests/accelerators/test_hpu.py Outdated Show resolved Hide resolved
tests/accelerators/test_hpu.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/hpu_parallel.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/hpu_parallel.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/hpu_parallel.py Outdated Show resolved Hide resolved
@jerome-habana jerome-habana requested a review from carmocca May 18, 2022 16:58
@kaushikb11 kaushikb11 added this to the 1.7 milestone May 19, 2022
@kaushikb11
Copy link
Contributor

Approved

@kaushikb11 kaushikb11 self-requested a review May 19, 2022 07:10
@kaushikb11 kaushikb11 merged commit 74941bb into Lightning-AI:master May 19, 2022
ashleve pushed a commit to ashleve/pytorch-lightning that referenced this pull request May 19, 2022
@jerome-habana @pre-commit-ci
@carmocca @ashleve
Enable all ddp params for hpu parallel strategy (Lightning-AI#13067)
68e3f36 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
@jerome-habana jerome-habana deleted the hpu_ddp branch May 19, 2022 12:13
@jerome-habana jerome-habana mentioned this pull request May 30, 2022
Merged
@carmocca carmocca added the feature Is an improvement or enhancement label May 30, 2022
@carmocca carmocca modified the milestones: 1.7, 1.6.x May 30, 2022
carmocca added a commit that referenced this pull request May 30, 2022
@jerome-habana @pre-commit-ci @carmocca
Enable all ddp params for hpu parallel strategy (#13067)
adc7214 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca added a commit that referenced this pull request May 31, 2022
@jerome-habana @pre-commit-ci @carmocca
Enable all ddp params for hpu parallel strategy (#13067)
35e6092 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca added a commit that referenced this pull request May 31, 2022
@jerome-habana @pre-commit-ci @carmocca
Enable all ddp params for hpu parallel strategy (#13067)
6e64183 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@jerome-habana @pre-commit-ci
@carmocca @lexierule
Enable all ddp params for hpu parallel strategy (#13067)
70f6744 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees
No one assigned
Labels
accelerator: hpu (external) Habana Processing Unit feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.
5 participants
@jerome-habana @kaushikb11 @carmocca @justusschock @rohitgr7