Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hpu hmp for bf16 alone #13028

Merged
merged 6 commits into from
May 12, 2022
Merged

Use hpu hmp for bf16 alone #13028

merged 6 commits into from
May 12, 2022

Conversation

jerome-habana
Copy link
Contributor

Signed-off-by: Jerome [email protected]

What does this PR do?

The precision plugin does unnecessary conversion even for fp32 inputs. Added check to mitigate it as it might cause issues between default op list vs user provided list

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the accelerator: hpu (external) Habana Processing Unit label May 11, 2022
Signed-off-by: Jerome <[email protected]>
@carmocca carmocca added this to the 1.6.x milestone May 11, 2022
@carmocca carmocca added the bug Something isn't working label May 11, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) May 11, 2022 13:55
@mergify mergify bot added the ready PRs ready to be merged label May 11, 2022
pytorch_lightning/plugins/precision/hpu.py Outdated Show resolved Hide resolved
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels May 11, 2022
auto-merge was automatically disabled May 12, 2022 03:22

Head branch was pushed to by a user without write access

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 12, 2022
@Borda Borda enabled auto-merge (squash) May 12, 2022 12:23
@Borda Borda merged commit fcf6e3e into Lightning-AI:master May 12, 2022
@jerome-habana jerome-habana deleted the hpu_hmp branch May 13, 2022 03:11
carmocca pushed a commit that referenced this pull request May 13, 2022
carmocca pushed a commit that referenced this pull request May 31, 2022
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: hpu (external) Habana Processing Unit bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants