Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant callback restore warning while tuning #13026

Merged
merged 6 commits into from
May 11, 2022
Merged

Avoid redundant callback restore warning while tuning #13026

merged 6 commits into from
May 11, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented May 10, 2022 •
edited by akihironitta
Loading

What does this PR do?

Fixes #12817

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @otaj @akihironitta @Borda @rohitgr7

@rohitgr7 rohitgr7 added bug Something isn't working tuner labels May 10, 2022
@rohitgr7 rohitgr7 added this to the 1.6.x milestone May 10, 2022
@rohitgr7 rohitgr7 force-pushed the fix/tuner_cb_restore branch from 4100327 to bd85fdd Compare May 10, 2022 11:33
@rohitgr7 rohitgr7 marked this pull request as ready for review May 10, 2022 11:43
carmocca
carmocca previously approved these changes May 10, 2022
View reviewed changes
@rohitgr7 rohitgr7 enabled auto-merge (squash) May 10, 2022 12:35
@carmocca carmocca dismissed their stale review May 10, 2022 12:38

Accidental approval

@carmocca carmocca removed this from the 1.6.x milestone May 10, 2022
@rohitgr7 rohitgr7 requested a review from carmocca May 10, 2022 12:45
@rohitgr7 rohitgr7 requested a review from SkafteNicki as a code owner May 10, 2022 12:50
carmocca
carmocca approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

akihironitta
akihironitta approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@akihironitta akihironitta added this to the 1.6.x milestone May 11, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 11, 2022
@rohitgr7 rohitgr7 merged commit 9881bf2 into master May 11, 2022
@rohitgr7 rohitgr7 deleted the fix/tuner_cb_restore branch May 11, 2022 14:11
carmocca pushed a commit that referenced this pull request May 13, 2022
@rohitgr7 @carmocca
Avoid redundant callback restore warning while tuning (#13026)
4818fa7
carmocca pushed a commit that referenced this pull request May 31, 2022
@rohitgr7 @carmocca
Avoid redundant callback restore warning while tuning (#13026)
c6cf5f2
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@rohitgr7 @lexierule
Avoid redundant callback restore warning while tuning (#13026)
9c54f7a
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged tuner
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.

"Please add the following callbacks" warning
4 participants
@rohitgr7 @Borda @carmocca @akihironitta