Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix epoch logging on train epoch end #13025

Merged
merged 8 commits into from
Jun 1, 2022
Merged

Fix epoch logging on train epoch end #13025

merged 8 commits into from
Jun 1, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented May 10, 2022

What does this PR do?

Fixes #12851

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @otaj @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@rohitgr7 rohitgr7 added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels May 10, 2022
@rohitgr7 rohitgr7 added this to the 1.6.x milestone May 10, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review May 10, 2022 11:43
@rohitgr7 rohitgr7 requested a review from carmocca May 10, 2022 11:58
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the for loop inside the test, I think it's much easier to see this way and it's fine to unroll since it's not long

@rohitgr7 rohitgr7 enabled auto-merge (squash) May 10, 2022 12:35
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 12, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels May 13, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 1, 2022
@rohitgr7 rohitgr7 merged commit 9445a84 into master Jun 1, 2022
@rohitgr7 rohitgr7 deleted the fix/epoch_logging branch June 1, 2022 09:05
carmocca added a commit that referenced this pull request Jun 1, 2022
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same step maps to different epoch values with TensorBoardLogger and on_epoch=True
4 participants