Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default int values being float #12989

Merged
merged 2 commits into from
May 6, 2022
Merged

Fix default int values being float #12989

merged 2 commits into from
May 6, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 5, 2022

What does this PR do?

Fixes #12978

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @mauvilsa

@carmocca carmocca added bug Something isn't working lightningcli pl.cli.LightningCLI labels May 5, 2022
@carmocca carmocca added this to the 1.6.x milestone May 5, 2022
@carmocca carmocca requested review from tchaton and SeanNaren as code owners May 5, 2022 20:25
@carmocca carmocca self-assigned this May 5, 2022
@Borda Borda requested a review from a team May 6, 2022 04:24
@mergify mergify bot added the ready PRs ready to be merged label May 6, 2022
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to read up on the underscore syntax first :D 🤯

@otaj otaj enabled auto-merge (squash) May 6, 2022 08:55
@otaj otaj merged commit 2697517 into master May 6, 2022
@otaj otaj deleted the bugfix/default-int-values branch May 6, 2022 10:24
carmocca added a commit that referenced this pull request May 9, 2022
carmocca added a commit that referenced this pull request May 31, 2022
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants