Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double precision during evaluation #12983

Merged
merged 6 commits into from
May 11, 2022
Merged

Fix double precision during evaluation #12983

merged 6 commits into from
May 11, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented May 5, 2022

What does this PR do?

Fixes #12982

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli @akihironitta @rohitgr7

@rohitgr7 rohitgr7 changed the title Fix double precision evaluation Fix double precision during evaluation May 5, 2022
@rohitgr7 rohitgr7 marked this pull request as draft May 5, 2022 13:47
@rohitgr7 rohitgr7 added bug Something isn't working precision: double Double precision trainer: validate labels May 5, 2022
@rohitgr7 rohitgr7 added this to the 1.6.x milestone May 5, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review May 5, 2022 14:02
CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 enabled auto-merge (squash) May 5, 2022 15:14
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels May 5, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/strategies/ddp.py Show resolved Hide resolved
pytorch_lightning/strategies/ddp_spawn.py Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from awaelchli May 8, 2022 09:29
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 8, 2022
@rohitgr7
Copy link
Contributor Author

gk

@rohitgr7 rohitgr7 merged commit 4011f37 into master May 11, 2022
@rohitgr7 rohitgr7 deleted the fix/double_prec_eval branch May 11, 2022 17:43
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working precision: double Double precision ready PRs ready to be merged trainer: validate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

precision=64 is broken with DDP with validate/test/predict
5 participants