Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Enable mixed precision in the Fully Sharded Strategy when precision=16 #12965

Merged
merged 2 commits into from
May 3, 2022

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented May 3, 2022

What does this PR do?

Fixes #12964.

Ensures we check for precision=16 as well to enable the correct flag in the fully sharded strategy.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @SeanNaren @awaelchli @rohitgr7 @akihironitta

@SeanNaren SeanNaren added bug Something isn't working strategy: fairscale fsdp (removed) Fully Sharded Data Parallel labels May 3, 2022
@SeanNaren SeanNaren added this to the 1.6.x milestone May 3, 2022
@SeanNaren SeanNaren requested a review from tchaton as a code owner May 3, 2022 14:48
@SeanNaren SeanNaren self-assigned this May 3, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 3, 2022
@SeanNaren SeanNaren enabled auto-merge (squash) May 3, 2022 15:13
@SeanNaren SeanNaren merged commit 4d06301 into master May 3, 2022
@SeanNaren SeanNaren deleted the fix/mixed_precision_fully_sharded branch May 3, 2022 15:40
carmocca pushed a commit that referenced this pull request May 3, 2022
…ision=16` (#12965)

* Fix fully sharded mixed precision setter

* Add CHANGELOG.md
carmocca pushed a commit that referenced this pull request May 3, 2022
…ision=16` (#12965)

* Fix fully sharded mixed precision setter

* Add CHANGELOG.md
lexierule pushed a commit that referenced this pull request May 3, 2022
…ision=16` (#12965)

* Fix fully sharded mixed precision setter

* Add CHANGELOG.md
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged strategy: fairscale fsdp (removed) Fully Sharded Data Parallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully Sharded does not enabled mixed precision for wrapped modules
6 participants