Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke parent DDP configuration for torch>1.10.2 #12912

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Invoke parent DDP configuration for torch>1.10.2 #12912

merged 3 commits into from
Apr 28, 2022

Conversation

jerome-habana
Copy link
Contributor

@jerome-habana jerome-habana commented Apr 28, 2022 •
edited
Loading

Signed-off-by: Jerome [email protected]

What does this PR do?

For torch> 1.10.2, hpu based ddp configuration was resulting in recursive calls due to self invocation.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11
Copy link
Contributor

@jerome-habana Could you update the Changelog please?

@kaushikb11 kaushikb11 added bug Something isn't working accelerator: hpu (external) Habana Processing Unit labels Apr 28, 2022
@kaushikb11 kaushikb11 added this to the 1.6.x milestone Apr 28, 2022
@kaushikb11 kaushikb11 added the priority: 0 High priority task label Apr 28, 2022
@jerome-habana jerome-habana mentioned this pull request Apr 28, 2022
Closed
12 tasks
@jerome-habana
update change log
172cd23 
Signed-off-by: Jerome <[email protected]>
@mergify mergify bot added the ready PRs ready to be merged label Apr 28, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 28, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 28, 2022
@carmocca carmocca enabled auto-merge (squash) April 28, 2022 16:50
@carmocca carmocca merged commit 6896f00 into Lightning-AI:master Apr 28, 2022
@jerome-habana jerome-habana deleted the hpu_parallel branch April 29, 2022 02:28
carmocca added a commit that referenced this pull request May 2, 2022
@jerome-habana @carmocca
Invoke parent DDP configuration for torch>1.10.2 (#12912)
38cad5f 
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca added a commit that referenced this pull request May 3, 2022
@jerome-habana @carmocca
Invoke parent DDP configuration for torch>1.10.2 (#12912)
9287a7f 
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request May 3, 2022
@jerome-habana @carmocca @lexierule
Invoke parent DDP configuration for torch>1.10.2 (#12912)
282cf47 
Co-authored-by: Carlos Mocholí <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
accelerator: hpu (external) Habana Processing Unit bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.
5 participants
@jerome-habana @kaushikb11 @Borda @carmocca @justusschock