Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number of references to LightningModule #12897

Merged
merged 13 commits into from
May 13, 2022
Merged

Fix number of references to LightningModule #12897

merged 13 commits into from
May 13, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Apr 27, 2022 •
edited by github-actions bot
Loading

What does this PR do?

I know, this looks way too hacky, the proposal in bug report proposes to deal with it in __del__ method. Problem is, the __del__ method will never be called, exactly because of this issue, because there will always be an internal reference to self. There will be accompanying PR to pytorch to fix it on their side

Fixes #12622

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @otaj @Borda @carmocca @justusschock @awaelchli @ananthsub @ninginthecloud @jjenniferdai @rohitgr7

@otaj otaj added bug Something isn't working lightningmodule pl.LightningModule labels Apr 27, 2022
@otaj otaj added this to the 1.6.x milestone Apr 27, 2022
@otaj otaj self-assigned this Apr 27, 2022
@mergify mergify bot removed the has conflicts label Apr 27, 2022
rohitgr7
rohitgr7 approved these changes Apr 27, 2022
View reviewed changes
tests/core/test_lightning_module.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@otaj @rohitgr7
Update CHANGELOG.md
acd3e3e 
Co-authored-by: Rohit Gupta <[email protected]>
@mergify mergify bot removed the has conflicts label Apr 27, 2022
carmocca
carmocca approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until PyTorch devs approve the change upstream to merge

pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Apr 27, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 28, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels May 4, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels May 10, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 12, 2022
@otaj otaj enabled auto-merge (squash) May 12, 2022 06:54
carmocca
carmocca approved these changes May 12, 2022
View reviewed changes
pytorch_lightning/utilities/imports.py Outdated Show resolved Hide resolved
@otaj otaj merged commit db7b036 into master May 13, 2022
@otaj otaj deleted the bugfix/weakref branch May 13, 2022 15:23
carmocca added a commit that referenced this pull request May 13, 2022
@otaj @rohitgr7 @carmocca
Fix number of references to LightningModule (#12897)
8c70e25 
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
ashleve pushed a commit to ashleve/pytorch-lightning that referenced this pull request May 13, 2022
@otaj @rohitgr7
@carmocca @ashleve
Fix number of references to LightningModule (Lightning-AI#12897)
6a1726a 
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
ashleve added a commit to ashleve/pytorch-lightning that referenced this pull request May 14, 2022
@ashleve
Revert "Fix number of references to LightningModule (Lightning-AI#12897…
8ce4e60 
…)"

This reverts commit 6a1726a.
carmocca added a commit that referenced this pull request May 31, 2022
@otaj @rohitgr7 @carmocca
Fix number of references to LightningModule (#12897)
acf443c 
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@otaj @rohitgr7
@carmocca @lexierule
Fix number of references to LightningModule (#12897)
b8e7d6d 
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@otaj otaj

Labels
bug Something isn't working lightningmodule pl.LightningModule ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.

sys.getrefcount() of a LightningModule
5 participants
@otaj @awaelchli @Borda @carmocca @rohitgr7