-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to ensure the checkpoint states are saved in a common filepath with deepspeed #12887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
added
bug
Something isn't working
checkpointing
Related to checkpointing
strategy: deepspeed
labels
Apr 26, 2022
rohitgr7
commented
Apr 26, 2022
rohitgr7
requested review from
tchaton,
SeanNaren,
awaelchli,
justusschock,
kaushikb11,
williamFalcon,
Borda and
carmocca
as code owners
April 26, 2022 14:18
carmocca
approved these changes
Apr 26, 2022
Any chance you could double-check this fix works for |
yes, works with stage_3 |
otaj
approved these changes
Apr 27, 2022
SeanNaren
approved these changes
Apr 27, 2022
carmocca
pushed a commit
that referenced
this pull request
Apr 27, 2022
…th deepspeed (#12887) Co-authored-by: Akihiro Nitta <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
May 3, 2022
…th deepspeed (#12887) Co-authored-by: Akihiro Nitta <[email protected]>
weiji14
added a commit
to weiji14/s2s2net
that referenced
this pull request
May 24, 2022
Get fix that ensures checkpoint states are saved in a common filepath with deepspeed Lightning-AI/pytorch-lightning#12887.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
checkpointing
Related to checkpointing
ready
PRs ready to be merged
strategy: deepspeed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12864
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @awaelchli @ananthsub @ninginthecloud @rohitgr7 @SeanNaren @akihironitta