Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to ensure the checkpoint states are saved in a common filepath with deepspeed #12887

Merged
merged 4 commits into from
Apr 27, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Apr 26, 2022

What does this PR do?

Fixes #12864

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @ananthsub @ninginthecloud @rohitgr7 @SeanNaren @akihironitta

@rohitgr7 rohitgr7 added bug Something isn't working checkpointing Related to checkpointing strategy: deepspeed labels Apr 26, 2022
@rohitgr7 rohitgr7 added this to the 1.6.x milestone Apr 26, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review April 26, 2022 14:18
tests/strategies/test_deepspeed_strategy.py Outdated Show resolved Hide resolved
tests/strategies/test_deepspeed_strategy.py Outdated Show resolved Hide resolved
tests/strategies/test_deepspeed_strategy.py Outdated Show resolved Hide resolved
@SeanNaren
Copy link
Contributor

Any chance you could double-check this fix works for deepspeed_stage_3? this should hopefully mean all the model partitions are saved in the same folder as well.

@rohitgr7
Copy link
Contributor Author

Any chance you could double-check this fix works for deepspeed_stage_3? this should hopefully mean all the model partitions are saved in the same folder as well.

yes, works with stage_3

@mergify mergify bot removed the has conflicts label Apr 27, 2022
@rohitgr7 rohitgr7 requested review from krshrimali and otaj April 27, 2022 09:57
@mergify mergify bot added the ready PRs ready to be merged label Apr 27, 2022
@carmocca carmocca merged commit 70754be into master Apr 27, 2022
@carmocca carmocca deleted the fix/deepspeed_filepath branch April 27, 2022 12:41
carmocca pushed a commit that referenced this pull request Apr 27, 2022
lexierule pushed a commit that referenced this pull request May 3, 2022
weiji14 added a commit to weiji14/s2s2net that referenced this pull request May 24, 2022
Get fix that ensures checkpoint states are saved in a common filepath with deepspeed Lightning-AI/pytorch-lightning#12887.
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checkpointing Related to checkpointing ready PRs ready to be merged strategy: deepspeed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimizer states are saved in different folders
5 participants