Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single instance of rich.console.Console throughout the codebase #12886

Merged
merged 9 commits into from
Apr 27, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Apr 26, 2022

What does this PR do?

Use a single instance of rich Console throughout the codebase, so that everything plays nicely together.

Fixes #12824

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @kaushikb11 @rohitgr7

@otaj otaj added bug Something isn't working progress bar: rich labels Apr 26, 2022
@otaj otaj added this to the 1.6.x milestone Apr 26, 2022
@otaj otaj requested a review from tchaton as a code owner April 26, 2022 11:49
@otaj otaj self-assigned this Apr 26, 2022
@otaj otaj changed the title Bugfix/rich console Use a single instance of rich.console.Console throughout the codebase Apr 26, 2022
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mergify mergify bot added the ready PRs ready to be merged label Apr 26, 2022
@carmocca carmocca enabled auto-merge (squash) April 26, 2022 17:20
@carmocca carmocca merged commit a414862 into master Apr 27, 2022
@carmocca carmocca deleted the bugfix/rich_console branch April 27, 2022 01:47
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working progress bar: rich ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich progress bar doesn't play nicely with other prints
4 participants