Fixed encoding issues on terminals that do not support unicode characters #12828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvitawa
requested review from
tchaton,
awaelchli,
justusschock and
carmocca
as code owners
for more information, see https://pre-commit.ci
carmocca
reviewed
Apr 21, 2022
There was a problem hiding this comment.
Two more things:
- Can you update the CHANGELOG? Section "Fixed"
- Can you add a test? I pushed a change where we use
file.encoding. You can mock the encoding to assert the behaviour under different values. The test can be added here https://github.com/PyTorchLightning/pytorch-lightning/blob/master/tests/trainer/logging_/test_eval_loop_logging.py
alvitawa
requested review from
williamFalcon,
Borda,
SeanNaren,
kaushikb11 and
rohitgr7
as code owners
for more information, see https://pre-commit.ci
|
I think this does it. But I cant try the test out on my machine due to some dependency issue. |
awaelchli
approved these changes
Apr 22, 2022
akihironitta
approved these changes
Apr 23, 2022
Co-authored-by: Akihiro Nitta <[email protected]>
for more information, see https://pre-commit.ci
carmocca
approved these changes
Apr 23, 2022
carmocca
approved these changes
Apr 25, 2022
otaj
pushed a commit
that referenced
this pull request
Apr 26, 2022
…ters (#12828) Co-authored-by: Carlos Mocholí <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Apr 27, 2022
…ters (#12828) Co-authored-by: Carlos Mocholí <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12823