-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threading support for legacy loading of checkpoints #12814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with multithreading
krshrimali
requested review from
Borda,
tchaton,
SeanNaren,
carmocca,
williamFalcon,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
April 20, 2022 06:25
Borda
reviewed
Apr 20, 2022
Update: working on adding tests for this PR, and then it should be ready for review. :) |
awaelchli
reviewed
Apr 20, 2022
krshrimali
force-pushed
the
fix/legacy/threading_load_checkpoints
branch
from
April 28, 2022 04:45
64ad880
to
99acdf2
Compare
krshrimali
force-pushed
the
fix/legacy/threading_load_checkpoints
branch
from
April 28, 2022 04:56
a5f6b33
to
a8fc820
Compare
for more information, see https://pre-commit.ci
carmocca
approved these changes
Apr 28, 2022
otaj
approved these changes
Apr 28, 2022
otaj
approved these changes
Apr 28, 2022
awaelchli
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great fix!
thanks for incorporating my suggestion!
carmocca
pushed a commit
that referenced
this pull request
May 2, 2022
carmocca
pushed a commit
that referenced
this pull request
May 3, 2022
lexierule
pushed a commit
that referenced
this pull request
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12557.
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda