Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threading support for legacy loading of checkpoints #12814

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Apr 20, 2022

What does this PR do?

Fixes #12557.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@krshrimali
Copy link
Contributor Author

Update: working on adding tests for this PR, and then it should be ready for review. :)

@krshrimali krshrimali force-pushed the fix/legacy/threading_load_checkpoints branch from 64ad880 to 99acdf2 Compare April 28, 2022 04:45
@krshrimali krshrimali force-pushed the fix/legacy/threading_load_checkpoints branch from a5f6b33 to a8fc820 Compare April 28, 2022 04:56
@krshrimali krshrimali marked this pull request as ready for review April 28, 2022 10:57
@krshrimali krshrimali requested review from awaelchli and Borda April 28, 2022 10:58
@mergify mergify bot added the ready PRs ready to be merged label Apr 28, 2022
@carmocca carmocca added this to the 1.6.x milestone Apr 28, 2022
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great fix!
thanks for incorporating my suggestion!

@awaelchli awaelchli enabled auto-merge (squash) April 28, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on multiple initializations in load_checkpoint() calls
5 participants