-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for ModelCheckpoint
monitors with dots
#12783
Merged
awaelchli
merged 6 commits into
Lightning-AI:master
from
HenryLau0220:bugfix/12770_ModelCheckpoint
Apr 21, 2022
Merged
Fix support for ModelCheckpoint
monitors with dots
#12783
awaelchli
merged 6 commits into
Lightning-AI:master
from
HenryLau0220:bugfix/12770_ModelCheckpoint
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch contains named formatting options containing dots
HenryLau0220
requested review from
williamFalcon,
tchaton,
carmocca,
Borda and
kaushikb11
as code owners
April 16, 2022 12:24
HenryLau0220
requested review from
SeanNaren,
awaelchli,
justusschock and
rohitgr7
as code owners
April 21, 2022 16:35
carmocca
changed the title
fix bug #12770: ModelCheckpoint can't work properly with filename whi…
Fix support for Apr 21, 2022
ModelCheckpoint
monitors with dots
carmocca
approved these changes
Apr 21, 2022
rohitgr7
approved these changes
Apr 21, 2022
awaelchli
approved these changes
Apr 21, 2022
otaj
pushed a commit
that referenced
this pull request
Apr 25, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Apr 27, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12770
Modify the ModelCheckpoint to support filename which contains named formatting options containing dots like this: filename="epoch={epoch}[email protected]={val/[email protected]:.4f}"
I refer to this https://stackoverflow.com/questions/7934620/python-dots-in-the-name-of-variable-in-a-format-string
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list: