Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for ModelCheckpoint monitors with dots #12783

Merged
merged 6 commits into from
Apr 21, 2022
Merged

Fix support for ModelCheckpoint monitors with dots #12783

merged 6 commits into from
Apr 21, 2022

Conversation

HenryLau0220
Copy link
Contributor

@HenryLau0220 HenryLau0220 commented Apr 16, 2022

What does this PR do?

Fixes #12770
Modify the ModelCheckpoint to support filename which contains named formatting options containing dots like this: filename="epoch={epoch}[email protected]={val/[email protected]:.4f}"
I refer to this https://stackoverflow.com/questions/7934620/python-dots-in-the-name-of-variable-in-a-format-string

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

…ch contains named formatting options containing dots
@carmocca carmocca self-assigned this Apr 21, 2022
@carmocca carmocca added bug Something isn't working callback: model checkpoint labels Apr 21, 2022
@carmocca carmocca modified the milestone: 1.6.x Apr 21, 2022
@carmocca carmocca changed the title fix bug #12770: ModelCheckpoint can't work properly with filename whi… Fix support for ModelCheckpoint monitors with dots Apr 21, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 21, 2022
@awaelchli awaelchli merged commit b155a63 into Lightning-AI:master Apr 21, 2022
otaj pushed a commit that referenced this pull request Apr 25, 2022
lexierule pushed a commit that referenced this pull request Apr 27, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working callback: model checkpoint ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelCheckpoint can't work properly with filename which contains named formatting options containing dots
4 participants