Replace meta_tags.csv with hparams.yaml #1271

S-aiueo32 · 2020-03-28T09:34:55Z

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure to update the docs?
Did you write any new necessary tests?
If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1212 .

Co-Authored-By: Jirka Borovec <[email protected]>

…m/S-aiueo32/pytorch-lightning into feature/support-hierarchical-dict

…lightning

pep8speaks · 2020-03-28T09:35:00Z

Hello @S-aiueo32! Thanks for updating this PR.

In the file pytorch_lightning/core/lightning.py:

Line 20:111: E501 line too long (117 > 110 characters)
Line 1575:111: E501 line too long (117 > 110 characters)

In the file tests/trainer/test_trainer.py:

Line 15:111: E501 line too long (118 > 110 characters)

Comment last updated at 2020-05-13 11:10:28 UTC

awaelchli

cool. maybe a test for saving to and loading from a yaml file would be good.

pytorch_lightning/core/saving.py

pytorch_lightning/loggers/tensorboard.py

Borda · 2020-03-29T00:08:08Z

requirements.txt

@@ -5,4 +5,4 @@ numpy>=1.16.4
 torch>=1.1
 tensorboard>=1.14
 future>=0.17.1  # required for builtins in setup.py
-
+pyyaml>=5.3.1


is it really the minimal version we can use?

it's the current latest version

Could we put there like 3.x or lover since we are using quite general features?

@S-aiueo32 Don't forget to also add it to the environment.yml file

mergify · 2020-03-30T22:29:18Z

This pull request is now in conflict... :(

Borda · 2020-04-02T22:53:59Z

@S-aiueo32 how is it going? it would be great to have it in next week release 0.7.2

S-aiueo32 · 2020-04-02T23:03:58Z

@Borda I'm sorry, but I'm too busy for about two weeks this week to be able to respond. I recognize that the major changes are complete and all that remains is testing and minor revisions. If you don't mind, could you let the core contributor take over the work?

williamFalcon · 2020-04-03T19:26:54Z

@Borda mind taking over this one?

mergify · 2020-04-05T15:13:34Z

This pull request is now in conflict... :(

Borda · 2020-04-08T20:54:01Z

changelog need to be rebased on new release #1419

Borda · 2020-04-11T07:29:37Z

@S-aiueo32 may you pls allow editing your PR, I have prepared to rebase, but don't have permission to push it... 🤖

S-aiueo32 · 2020-04-12T07:54:33Z

@Borda confirmed?

Co-authored-by: Adrian Wälchli <[email protected]>

S-aiueo32 · 2020-05-13T11:26:24Z

@Borda @awaelchli @williamFalcon All checks pass, thanks!

Borda · 2020-05-13T12:13:06Z

it looks good to me, I have pinged @PyTorchLightning/core-contributors to get this done

justusschock

LGTM

Borda · 2020-05-13T13:05:51Z

@S-aiueo32 Great work! and thx for your patience 🦝

jeremyjordan

shall we include a test for tests/test_deprecated.py?

Borda · 2020-05-13T13:32:39Z

shall we include a test for tests/test_deprecated.py?

completely forgot... @S-aiueo32 mind make followup or with deprecation tests

S-aiueo32 and others added 13 commits March 14, 2020 02:26

Add support for hierarchical dict

af9555a

Support nested Namespace

29ae37c

Resolving conflict with the current master

fc7fe7c

Add docstring

8ced285

Migrate hparam flattening to each logger

c2e00a4

Modify URLs in CHANGELOG

117acd7

typo

e128430

Simplify the conditional branch about Namespace

5497d10

Co-Authored-By: Jirka Borovec <[email protected]>

Update CHANGELOG.md

891c600

Co-Authored-By: Jirka Borovec <[email protected]>

added examples section to docstring

d54c597

Merge branch 'feature/support-hierarchical-dict' of https://github.co…

52fe621

…m/S-aiueo32/pytorch-lightning into feature/support-hierarchical-dict

renamed _dict -> input_dict

377b7c4

Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-…

942895f

…lightning

awaelchli reviewed Mar 28, 2020

View reviewed changes

pytorch_lightning/core/saving.py Outdated Show resolved Hide resolved

pytorch_lightning/loggers/tensorboard.py Show resolved Hide resolved

Borda added the feature Is an improvement or enhancement label Mar 29, 2020

Borda reviewed Mar 29, 2020

View reviewed changes

mergify bot requested a review from a team March 30, 2020 22:33

Borda added this to the 0.7.2 milestone Apr 2, 2020

Borda self-assigned this Apr 2, 2020

williamFalcon modified the milestones: 0.7.2, 0.7.3 Apr 3, 2020

Borda and others added 20 commits May 13, 2020 10:48

add savings

ec76bef

warn

19d7369

docstrings

1bfdc06

tests

4383b7e

Apply suggestions from code review

290fd0f

saving

1124490

Apply suggestions from code review

cebd3ed

use default

ecead94

remove logging

34f5b79

typo fixes

f312053

update docs

2a165af

update CHANGELOG

b4c40ad

clean imports

f1d4502

add blank lines

02d2537

Update pytorch_lightning/core/lightning.py

1fc4ffd

Co-authored-by: Adrian Wälchli <[email protected]>

Update pytorch_lightning/core/lightning.py

63d7abd

Co-authored-by: Adrian Wälchli <[email protected]>

back to namespace

d4f28e6

add docs

53c0a40

test fix

95a28ad

update dependencies

5d27e34

S-aiueo32 force-pushed the feature/replace-mata-tags-with-yaml branch from bc64951 to 5d27e34 Compare May 13, 2020 11:05

add space

df6cd16

justusschock approved these changes May 13, 2020

View reviewed changes

Borda requested a review from jeremyjordan May 13, 2020 13:04

Borda merged commit 22d7d03 into Lightning-AI:master May 13, 2020

jeremyjordan approved these changes May 13, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace meta_tags.csv with hparams.yaml #1271

Replace meta_tags.csv with hparams.yaml #1271

S-aiueo32 commented Mar 28, 2020 •

edited

Loading

pep8speaks commented Mar 28, 2020 •

edited

Loading

awaelchli left a comment

Borda Mar 29, 2020

S-aiueo32 Mar 29, 2020

Borda Mar 29, 2020

awaelchli Apr 1, 2020

mergify bot commented Mar 30, 2020

Borda commented Apr 2, 2020

S-aiueo32 commented Apr 2, 2020

williamFalcon commented Apr 3, 2020

mergify bot commented Apr 5, 2020

Borda commented Apr 8, 2020

Borda commented Apr 11, 2020

S-aiueo32 commented Apr 12, 2020 •

edited by Borda

Loading

S-aiueo32 commented May 13, 2020

Borda commented May 13, 2020

justusschock left a comment

Borda commented May 13, 2020

jeremyjordan left a comment

Borda commented May 13, 2020

Replace meta_tags.csv with hparams.yaml #1271

Replace meta_tags.csv with hparams.yaml #1271

Conversation

S-aiueo32 commented Mar 28, 2020 • edited Loading

Before submitting

What does this PR do?

pep8speaks commented Mar 28, 2020 • edited Loading

Comment last updated at 2020-05-13 11:10:28 UTC

awaelchli left a comment

Choose a reason for hiding this comment

Borda Mar 29, 2020

Choose a reason for hiding this comment

S-aiueo32 Mar 29, 2020

Choose a reason for hiding this comment

Borda Mar 29, 2020

Choose a reason for hiding this comment

awaelchli Apr 1, 2020

Choose a reason for hiding this comment

mergify bot commented Mar 30, 2020

Borda commented Apr 2, 2020

S-aiueo32 commented Apr 2, 2020

williamFalcon commented Apr 3, 2020

mergify bot commented Apr 5, 2020

Borda commented Apr 8, 2020

Borda commented Apr 11, 2020

S-aiueo32 commented Apr 12, 2020 • edited by Borda Loading

S-aiueo32 commented May 13, 2020

Borda commented May 13, 2020

justusschock left a comment

Choose a reason for hiding this comment

Borda commented May 13, 2020

jeremyjordan left a comment

Choose a reason for hiding this comment

Borda commented May 13, 2020

S-aiueo32 commented Mar 28, 2020 •

edited

Loading

pep8speaks commented Mar 28, 2020 •

edited

Loading

S-aiueo32 commented Apr 12, 2020 •

edited by Borda

Loading