Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trainer.logger deprecation message #12671

Merged
merged 7 commits into from
Apr 27, 2022
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Apr 8, 2022

What does this PR do?

Fixes slack report:

I’m passing in multiple loggers to the trainer and getting spammed with
UserWarning: Using trainer.logger when Trainer is configured to use multiple loggers. This behavior will change in v1.8 when LoggerCollection is removed, and trainer.logger will return the first logger in trainer.loggers
Is there something I need to be doing differently to avoid this warning?

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @awaelchli @edward-io @Borda @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@carmocca carmocca added the bug Something isn't working label Apr 8, 2022
@carmocca carmocca added this to the 1.6.x milestone Apr 8, 2022
@carmocca carmocca self-assigned this Apr 8, 2022
@carmocca carmocca added the logger Related to the Loggers label Apr 13, 2022
@carmocca carmocca marked this pull request as ready for review April 26, 2022 16:56
@mergify mergify bot added the ready PRs ready to be merged label Apr 27, 2022
@carmocca carmocca enabled auto-merge (squash) April 27, 2022 13:32
@carmocca carmocca merged commit 10c7a7c into master Apr 27, 2022
@carmocca carmocca deleted the bug/depr-message-logger branch April 27, 2022 14:11
carmocca added a commit that referenced this pull request Apr 27, 2022
lexierule pushed a commit that referenced this pull request May 3, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants