Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce eval shuffle warning only for default samplers #12653

Merged
merged 10 commits into from
May 2, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Apr 7, 2022

What does this PR do?

Fixes #12648
Fixes #11856

For reviewers: a179fdc is the only commit that needs review. Rest is just moving tests from test_data_loading to test_data_connector since we have deprecated data_loading. Moved them since it becomes hard to find tests that belong to data_connector.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @ninginthecloud @rohitgr7

@rohitgr7 rohitgr7 added bug Something isn't working data handling Generic data-related topic labels Apr 7, 2022
@rohitgr7 rohitgr7 added this to the 1.6.x milestone Apr 7, 2022
tests/helpers/utils.py Outdated Show resolved Hide resolved
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Apr 7, 2022

for reviewers: a179fdc is the only commit that needs review. Rest is just moving tests from test_data_loading to test_data_connector since we have deprecated data_loading. Moved them since it becomes hard to find tests that belong to data_connector.

@rohitgr7 rohitgr7 marked this pull request as ready for review April 7, 2022 11:28
tests/helpers/utils.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from carmocca April 8, 2022 08:25
@rohitgr7 rohitgr7 requested a review from awaelchli April 10, 2022 17:56
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@mergify mergify bot added the ready PRs ready to be merged label Apr 11, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 19, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 22, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 25, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) May 2, 2022 15:04
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 2, 2022
@carmocca carmocca modified the milestone: 1.6.x May 2, 2022
@rohitgr7 rohitgr7 merged commit eebba9e into master May 2, 2022
@rohitgr7 rohitgr7 deleted the ref/eval_warning branch May 2, 2022 16:11
carmocca added a commit that referenced this pull request May 3, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca added a commit that referenced this pull request May 3, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request May 3, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
4 participants