-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce eval shuffle warning only for default samplers #12653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
added
bug
Something isn't working
data handling
Generic data-related topic
labels
Apr 7, 2022
rohitgr7
commented
Apr 7, 2022
for reviewers: a179fdc is the only commit that needs review. Rest is just moving tests from |
rohitgr7
requested review from
tchaton,
SeanNaren,
carmocca,
Borda,
williamFalcon,
awaelchli,
justusschock and
kaushikb11
as code owners
April 7, 2022 11:28
carmocca
reviewed
Apr 7, 2022
rohitgr7
commented
Apr 7, 2022
awaelchli
reviewed
Apr 10, 2022
awaelchli
approved these changes
Apr 10, 2022
krshrimali
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
rohitgr7
commented
Apr 11, 2022
carmocca
force-pushed
the
ref/eval_warning
branch
from
April 22, 2022 15:19
e9fc6d9
to
a030de3
Compare
carmocca
force-pushed
the
ref/eval_warning
branch
from
April 22, 2022 15:21
959d28b
to
2875dc1
Compare
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Apr 22, 2022
carmocca
approved these changes
Apr 22, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
May 2, 2022
carmocca
approved these changes
May 2, 2022
carmocca
added a commit
that referenced
this pull request
May 3, 2022
Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
carmocca
added a commit
that referenced
this pull request
May 3, 2022
Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
May 3, 2022
Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12648
Fixes #11856
For reviewers: a179fdc is the only commit that needs review. Rest is just moving tests from test_data_loading to test_data_connector since we have deprecated data_loading. Moved them since it becomes hard to find tests that belong to data_connector.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @awaelchli @ninginthecloud @rohitgr7