Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose deprecated arguments from logger base interface #12609

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Apr 4, 2022

What does this PR do?

jsonargparse includes the parent's arguments in the config when variadic **kwargs are included.

This means we need to explicitly list them so they don't become part of **kwargs. Now we pass them to super().__init__() so deprecation messages are raised.

I did not update the docstring of these logger classes as these are deprecated and it's already in the parent's docstring.

Fixes #12529

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @awaelchli @morganmcg1 @AyushExel @borisdayma @scottire @manangoel99 @edward-io @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@carmocca carmocca added this to the 1.6.x milestone Apr 4, 2022
@carmocca carmocca self-assigned this Apr 4, 2022
@carmocca carmocca enabled auto-merge (squash) April 6, 2022 15:01
@mergify mergify bot added the ready PRs ready to be merged label Apr 6, 2022
@carmocca carmocca merged commit 0a72efd into master Apr 6, 2022
@carmocca carmocca deleted the bugfix/cli-tblogger-args branch April 6, 2022 16:47
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger: comet logger: neptune logger: tensorboard logger: wandb Weights & Biases ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI instances logger raise error after upgraded to 1.6.0
4 participants