Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support auto_select_gpus with accelerator and devices api #12608

Merged
merged 18 commits into from
Apr 12, 2022
Merged

Support auto_select_gpus with accelerator and devices api #12608

merged 18 commits into from
Apr 12, 2022

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Apr 4, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Supports #12590

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @justusschock @kaushikb11 @awaelchli @akihironitta

@kaushikb11 kaushikb11 added the priority: 0 High priority task label Apr 5, 2022
@kaushikb11 kaushikb11 added this to the 1.6.x milestone Apr 5, 2022
@kaushikb11 kaushikb11 self-assigned this Apr 5, 2022
@kaushikb11 kaushikb11 added accelerator: cuda Compute Unified Device Architecture GPU bug Something isn't working labels Apr 5, 2022
@kaushikb11 kaushikb11 mentioned this pull request Apr 11, 2022
Merged
11 tasks
@kaushikb11 kaushikb11 force-pushed the fix/auto_select_gpu branch from 73beef4 to e679ca8 Compare April 11, 2022 06:08
@kaushikb11 kaushikb11 marked this pull request as ready for review April 11, 2022 09:16
@mergify mergify bot removed the has conflicts label Apr 12, 2022
@kaushikb11 kaushikb11 mentioned this pull request Apr 12, 2022
Merged
12 tasks
carmocca
carmocca approved these changes Apr 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/tuner/auto_gpu_select.py Outdated Show resolved Hide resolved
tests/trainer/properties/test_auto_gpu_select.py Outdated Show resolved Hide resolved
tests/trainer/properties/test_auto_gpu_select.py Outdated Show resolved Hide resolved
rohitgr7
rohitgr7 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify bot added the ready PRs ready to be merged label Apr 12, 2022
awaelchli
awaelchli approved these changes Apr 12, 2022
View reviewed changes
pytorch_lightning/tuner/auto_gpu_select.py Outdated Show resolved Hide resolved
pytorch_lightning/tuner/auto_gpu_select.py Outdated Show resolved Hide resolved
tests/trainer/properties/test_auto_gpu_select.py Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) April 12, 2022 19:35
@awaelchli awaelchli merged commit 77a0223 into master Apr 12, 2022
@awaelchli awaelchli deleted the fix/auto_select_gpu branch April 12, 2022 21:28
rohitgr7 pushed a commit that referenced this pull request Apr 13, 2022
@kaushikb11 @awaelchli @rohitgr7
Support auto_select_gpus with accelerator and devices api (#12608)
0c65e00 
Co-authored-by: Adrian Wälchli <[email protected]>
rohitgr7 pushed a commit that referenced this pull request Apr 13, 2022
@kaushikb11 @awaelchli @rohitgr7
Support auto_select_gpus with accelerator and devices api (#12608)
60ddc15 
Co-authored-by: Adrian Wälchli <[email protected]>
rohitgr7 pushed a commit that referenced this pull request Apr 13, 2022
@kaushikb11 @awaelchli @rohitgr7
Support auto_select_gpus with accelerator and devices api (#12608)
17404a5 
Co-authored-by: Adrian Wälchli <[email protected]>
lexierule pushed a commit that referenced this pull request Apr 13, 2022
@kaushikb11 @awaelchli @lexierule
Support auto_select_gpus with accelerator and devices api (#12608)
2187f30 
Co-authored-by: Adrian Wälchli <[email protected]>
@awaelchli awaelchli mentioned this pull request May 15, 2022
Closed
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

@kaushikb11 kaushikb11

Labels
accelerator: cuda Compute Unified Device Architecture GPU bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.
4 participants
@kaushikb11 @awaelchli @carmocca @rohitgr7