-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rank_zero_only
decorator for LSF environments
#12587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
Borda,
tchaton,
SeanNaren,
carmocca,
williamFalcon,
justusschock,
kaushikb11 and
rohitgr7
as code owners
April 3, 2022 23:07
awaelchli
changed the title
Fix
Update Apr 4, 2022
rank_zero_only
decorator for LSF environmentsrank_zero_only
decorator for LSF environments
carmocca
approved these changes
Apr 4, 2022
kaushikb11
approved these changes
Apr 4, 2022
four4fish
approved these changes
Apr 4, 2022
ananthsub
approved these changes
Apr 4, 2022
rohitgr7
approved these changes
Apr 4, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Apr 7, 2022
rohitgr7
pushed a commit
that referenced
this pull request
Apr 12, 2022
lexierule
pushed a commit
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12583
The rank_zero_only decorator accesses a global variable to determine the rank. This is so because the decorator has no access to the trainer. When a logger makes a call to self.experiment before the trainer is instantiated (and the cluster environment with global_rank etc. is available), the rank must be determined from the environment variables directly. So far, only the canonical RANK and slurm variables were checked. Since LSF is supported directly by Lightning, we should include the environment variable in the global rank utility.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @awaelchli