Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strategy argument being case insensitive #12528

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Mar 30, 2022

What does this PR do?

Fixes #12526

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@kaushikb11 kaushikb11 added bug Something isn't working strategy labels Mar 30, 2022
@kaushikb11 kaushikb11 added this to the 1.7.x milestone Mar 30, 2022
@kaushikb11 kaushikb11 removed the bug Something isn't working label Mar 30, 2022
@kaushikb11 kaushikb11 requested a review from ethanwharris March 30, 2022 12:39
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this! 😃

@kaushikb11 kaushikb11 enabled auto-merge (squash) March 30, 2022 12:50
@mergify mergify bot added the ready PRs ready to be merged label Mar 30, 2022
@carmocca carmocca modified the milestones: 1.7.x, 1.6.x Mar 30, 2022
@carmocca
Copy link
Contributor

@kaushikb11 bug-fixes go into 1.6.x since we just released 1.6.0

@kaushikb11 kaushikb11 merged commit 32e68c5 into master Mar 30, 2022
@kaushikb11 kaushikb11 deleted the strategy/case branch March 30, 2022 14:19
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged strategy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer strategy argument is case sensitive
4 participants