Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging to loggers with multiple eval dataloaders #12454

Merged
merged 10 commits into from
Mar 28, 2022
Merged

Fix logging to loggers with multiple eval dataloaders #12454

merged 10 commits into from
Mar 28, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Mar 25, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #11907

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@rohitgr7 rohitgr7 added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Mar 25, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Mar 25, 2022
@rohitgr7 rohitgr7 self-assigned this Mar 25, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review March 25, 2022 12:43
carmocca
carmocca approved these changes Mar 25, 2022
View reviewed changes
tests/trainer/logging_/test_eval_loop_logging.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/dataloader/evaluation_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/dataloader/evaluation_loop.py Outdated Show resolved Hide resolved
tests/trainer/logging_/test_eval_loop_logging.py Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low confidence review

tests/loops/test_evaluation_loop.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 27, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) March 27, 2022 16:59
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Mar 27, 2022
krshrimali
krshrimali approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 28, 2022
@rohitgr7 rohitgr7 merged commit 59b0ccb into master Mar 28, 2022
@rohitgr7 rohitgr7 deleted the bug/multi_dl_eval_logs branch March 28, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@krshrimali krshrimali krshrimali approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@rohitgr7 rohitgr7

Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Validation on epoch metrics not logging for multiple data loaders on 1.60dev
4 participants
@rohitgr7 @awaelchli @carmocca @krshrimali