Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AcceleratorConnector.tpu_cores and Deprecate Trainer.tpu_cores #12437

Merged
merged 8 commits into from
Mar 29, 2022

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Mar 24, 2022

What does this PR do?

Part of #11449 : remove unused properties in accelerator_connector: tpu_cores
Part of #12171 : deprecate device related properties in Trainer that is accessed from accelerator_connector: tpu_cores

AcceleratorConnector.tpu_cores was not meant to be public. It's removed from AcceleratorConnector and deprecated in Trainer in favor of using Trainer.num_devices

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@DuYicong515 DuYicong515 force-pushed the refactor/tpu_cores branch 3 times, most recently from b469397 to c032dea Compare March 25, 2022 23:45
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 27, 2022
tests/deprecated_api/test_remove_1-7.py Outdated Show resolved Hide resolved
@carmocca carmocca requested a review from kaushikb11 March 28, 2022 15:38
@Borda Borda added this to the 2.0 milestone Mar 28, 2022
@carmocca carmocca merged commit 534aa17 into Lightning-AI:master Mar 29, 2022
@carmocca carmocca modified the milestones: 2.0, 1.6 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation ready PRs ready to be merged trainer: connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants