-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Trainer.gpus
#12436
Merged
Merged
Deprecate Trainer.gpus
#12436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuYicong515
requested review from
williamFalcon,
tchaton,
awaelchli,
carmocca,
Borda,
kaushikb11,
SeanNaren,
justusschock and
rohitgr7
as code owners
March 24, 2022 05:19
DuYicong515
force-pushed
the
refactor/gpus
branch
from
March 24, 2022 06:20
f8f34ad
to
35d9765
Compare
ananthsub
approved these changes
Mar 24, 2022
DuYicong515
force-pushed
the
refactor/gpus
branch
from
March 24, 2022 19:00
35d9765
to
461aba2
Compare
DuYicong515
force-pushed
the
refactor/gpus
branch
from
March 24, 2022 21:10
5d2229d
to
13ddc56
Compare
DuYicong515
force-pushed
the
refactor/gpus
branch
from
March 25, 2022 01:11
13ddc56
to
1021c5a
Compare
akihironitta
approved these changes
Mar 25, 2022
rohitgr7
approved these changes
Mar 25, 2022
carmocca
approved these changes
Mar 25, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
akihironitta
approved these changes
Mar 26, 2022
awaelchli
approved these changes
Mar 27, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #12171: deprecate device related trainer properties: gpus
Trainer argument
gpus
is also being deprecated in #10410Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃