Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PyTorch 1.7 support #12432

Merged
merged 6 commits into from
Mar 27, 2022
Merged

Drop PyTorch 1.7 support #12432

merged 6 commits into from
Mar 27, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 24, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #12161

Does your PR introduce any breaking changes? If yes, please list them.

Drops PyTorch 1.7 support from our codebase

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @justusschock @awaelchli @rohitgr7 @Borda

@carmocca carmocca added this to the 1.6 milestone Mar 24, 2022
@carmocca carmocca self-assigned this Mar 24, 2022
@carmocca carmocca added the breaking change Includes a breaking change label Mar 24, 2022
@carmocca carmocca marked this pull request as ready for review March 24, 2022 13:13
Borda
Borda approved these changes Mar 24, 2022
View reviewed changes
tests/models/test_horovod.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 24, 2022
@carmocca carmocca enabled auto-merge (squash) March 24, 2022 19:26
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Mar 25, 2022
krshrimali
krshrimali approved these changes Mar 25, 2022
View reviewed changes
pytorch_lightning/strategies/ddp.py Outdated Show resolved Hide resolved
tests/accelerators/test_accelerator_connector.py Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 25, 2022
akihironitta
akihironitta approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove 1.7.* from our script as well?

https://github.com/PyTorchLightning/pytorch-lightning/blob/28dac0c8d9bba4331793c932694eda4eab0bb94e/requirements/adjust-versions.py#L18-L19

pytorch_lightning/trainer/connectors/data_connector.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/data_connector.py Outdated Show resolved Hide resolved
@carmocca carmocca merged commit 939d56c into master Mar 27, 2022
@carmocca carmocca deleted the feat/drop-pytorch1.7-support branch March 27, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@krshrimali krshrimali krshrimali approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@carmocca carmocca

Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Drop PyTorch 1.7 support
6 participants
@carmocca @awaelchli @Borda @krshrimali @akihironitta @rohitgr7