Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelCheckpoint's save_last now ignores every_n_epochs #12418

Merged
merged 13 commits into from
Mar 24, 2022
Merged

ModelCheckpoint's save_last now ignores every_n_epochs #12418

merged 13 commits into from
Mar 24, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 23, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #12391
And other minor bugs I noticed while working on this.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @tchaton @rohitgr7 @akihironitta @carmocca @awaelchli @ninginthecloud @jjenniferdai

@carmocca carmocca added bug Something isn't working callback: model checkpoint labels Mar 23, 2022
@carmocca carmocca added this to the 1.6 milestone Mar 23, 2022
@carmocca carmocca self-assigned this Mar 23, 2022
@carmocca carmocca changed the title Fix ModelCheckpoint trigger interactions ModelCheckpoint's save_last now ignores every_n_epochs Mar 23, 2022
carmocca
carmocca commented Mar 23, 2022
View reviewed changes
pytorch_lightning/callbacks/model_checkpoint.py
# Mode 2: save monitor=None checkpoints
self._save_none_monitor_checkpoint(trainer, monitor_candidates)
# Mode 3: save last checkpoints
# TODO: unused method. deprecate it
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left for a follow-up PR

@carmocca carmocca marked this pull request as ready for review March 23, 2022 03:06
krshrimali
krshrimali approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @carmocca! Looks really good to me, I just have a few questions for my knowledge and a minor test extension suggestion. Shouldn't block merging this PR once everyone concerned is happy with it :)

pytorch_lightning/callbacks/model_checkpoint.py Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
@carmocca carmocca added the priority: 0 High priority task label Mar 23, 2022
@carmocca carmocca mentioned this pull request Mar 23, 2022
Merged
10 tasks
@mergify mergify bot added the ready PRs ready to be merged label Mar 23, 2022
rohitgr7
rohitgr7 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! very small comments.

pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
@carmocca carmocca enabled auto-merge (squash) March 24, 2022 13:17
@carmocca carmocca merged commit 71e0ddb into master Mar 24, 2022
@carmocca carmocca deleted the bugfix/mc-every-n-epochs branch March 24, 2022 19:06
@carmocca carmocca mentioned this pull request Mar 25, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krshrimali krshrimali krshrimali approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Borda approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

@carmocca carmocca

Labels
bug Something isn't working callback: model checkpoint priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Fix interaction with save_last and every_n_epochs
5 participants
@carmocca @ananthsub @Borda @krshrimali @rohitgr7