-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AccleratorConnector.num_ipus
and deprecate Trainer.ipus
#12386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuYicong515
requested review from
williamFalcon,
tchaton,
awaelchli,
SeanNaren,
carmocca,
Borda,
justusschock,
kaushikb11 and
rohitgr7
as code owners
March 21, 2022 05:25
krshrimali
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @DuYicong515! Left minor comments, can you please take a look?
rohitgr7
approved these changes
Mar 21, 2022
carmocca
approved these changes
Mar 21, 2022
ananthsub
approved these changes
Mar 21, 2022
four4fish
approved these changes
Mar 21, 2022
Borda
approved these changes
Mar 21, 2022
DuYicong515
force-pushed
the
refactor/num_ipus
branch
from
March 21, 2022 18:03
31702d0
to
4934603
Compare
kaushikb11
reviewed
Mar 21, 2022
for more information, see https://pre-commit.ci
tchaton
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Mar 22, 2022
12 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #11449 : remove unused properties in accelerator_connector: num_ipus
Part of #12171 : deprecate device related properties in Trainer that is accessed from accelerator_connector: ipus
AcceleratorConnector.num_ipus
was not meant to be public. It's removed from AcceleratorConnector and deprecatedTrainer.ipus
in favor of usingTrainer.num_devices if isinstance(Trainer.accelerator, IPUAccelerator) else 0
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃