Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AccleratorConnector.num_ipus and deprecate Trainer.ipus #12386

Merged
merged 7 commits into from
Mar 23, 2022

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Mar 21, 2022

What does this PR do?

Part of #11449 : remove unused properties in accelerator_connector: num_ipus
Part of #12171 : deprecate device related properties in Trainer that is accessed from accelerator_connector: ipus

AcceleratorConnector.num_ipus was not meant to be public. It's removed from AcceleratorConnector and deprecated Trainer.ipus in favor of using Trainer.num_devices if isinstance(Trainer.accelerator, IPUAccelerator) else 0

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DuYicong515! Left minor comments, can you please take a look?

tests/accelerators/test_ipu.py Outdated Show resolved Hide resolved
tests/accelerators/test_ipu.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 21, 2022
@mergify mergify bot removed the has conflicts label Mar 21, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot removed the ready PRs ready to be merged label Mar 22, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Mar 22, 2022
@rohitgr7 rohitgr7 added deprecation Includes a deprecation code quality labels Mar 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 22, 2022
@ananthsub ananthsub enabled auto-merge (squash) March 23, 2022 06:51
@ananthsub ananthsub merged commit 491fa02 into Lightning-AI:master Mar 23, 2022
@DuYicong515 DuYicong515 deleted the refactor/num_ipus branch March 24, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants