Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Trainer.use_amp #12312

Merged
merged 5 commits into from
Mar 18, 2022
Merged

Deprecate Trainer.use_amp #12312

merged 5 commits into from
Mar 18, 2022

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Mar 12, 2022 •
edited by akihironitta
Loading

What does this PR do?

Fixes #12307

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz added this to the 1.6 milestone Mar 12, 2022
@ananthsub ananthsub added deprecation Includes a deprecation trainer labels Mar 14, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 15, 2022
@daniellepintz
Copy link
Contributor Author

Ready to be merged

@mergify mergify bot removed the has conflicts label Mar 18, 2022
@ananthsub ananthsub enabled auto-merge (squash) March 18, 2022 05:59
@ananthsub ananthsub merged commit 601948a into Lightning-AI:master Mar 18, 2022
@daniellepintz daniellepintz deleted the depr_use_amp branch March 18, 2022 13:05
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
deprecation Includes a deprecation ready PRs ready to be merged trainer
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Deprecate Trainer.use_amp
5 participants
@daniellepintz @ananthsub @awaelchli @akihironitta @rohitgr7