-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow log to an existing run ID in MLflow with MLFlowLogger #12290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution. Would you be able to add a test under tests/loggers/test_mlflow.py?
Co-authored-by: Adrian Wälchli <[email protected]>
@Kr4is we are currently in a feature freeze for the Lightning 1.6 release, which means we only merge bugfix and priority PRs. This feature may have to wait until 1.6 is released and 1.7 development starts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
Currently MLflow logger is not able to use an existing run to upload new log information. This PR allows give a run_id to de MLflow logger constructor in order to use this existing run to log there the information. If the run_id doesn't exists a warning is shown informing about this and a new run is created, like the current MLflow logger constructor works.
Fixes #12287
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃