Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Strategy.process_dataloader in data_connector.py #12251

Merged
merged 5 commits into from
Mar 23, 2022
Merged

Call Strategy.process_dataloader in data_connector.py #12251

merged 5 commits into from
Mar 23, 2022

Conversation

ninginthecloud
Copy link
Contributor

@ninginthecloud ninginthecloud commented Mar 7, 2022 •
edited
Loading

What does this PR do?

Fixes #12213

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ninginthecloud ninginthecloud added this to the 1.6 milestone Mar 7, 2022
@ninginthecloud ninginthecloud added data handling Generic data-related topic strategy labels Mar 7, 2022
@ninginthecloud ninginthecloud marked this pull request as ready for review March 7, 2022 06:01
krshrimali
krshrimali reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a minor comment for you to take a look. Apart from that, if this PR looks good to everyone, do you think it's a good idea to update the function docstring with something like, "Calls the strategy's process_dataloader method"? (or anything that you feel is appropriate). This is the docstring I am referring to:

https://github.com/PyTorchLightning/pytorch-lightning/blob/7ca8c86c9d612363bc1895c8e1d01b5b4779e942/pytorch_lightning/trainer/connectors/data_connector.py#L277-L281

pytorch_lightning/trainer/connectors/data_connector.py Show resolved Hide resolved
@ananthsub ananthsub changed the title Move process dataloader to data_connector.py Call Strategy.process_dataloader in data_connector.py Mar 7, 2022
ananthsub
ananthsub approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the changelog too

@ninginthecloud ninginthecloud force-pushed the move_process_dataloader branch from 7ca8c86 to 2f55dc9 Compare March 7, 2022 19:44
krshrimali
krshrimali approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ninginthecloud! Just a minor nit with changelog

CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/data_connector.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 8, 2022
@ninginthecloud ninginthecloud force-pushed the move_process_dataloader branch from 2f55dc9 to 8249818 Compare March 8, 2022 07:24
@ananthsub ananthsub enabled auto-merge (squash) March 9, 2022 08:34
@ninginthecloud
Copy link
Contributor Author

Hi, code owners, @Borda, @SeanNaren, @carmocca , @tchaton , would you like to take a look of this PR and give an approval? Thanks a lot.

auto-merge was automatically disabled March 23, 2022 22:20

Head branch was pushed to by a user without write access

@ninginthecloud ninginthecloud force-pushed the move_process_dataloader branch from b4d0667 to 5095365 Compare March 23, 2022 22:20
@ananthsub ananthsub enabled auto-merge (squash) March 23, 2022 22:24
@ananthsub ananthsub merged commit a9bfcc7 into Lightning-AI:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@krshrimali krshrimali krshrimali approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
data handling Generic data-related topic ready PRs ready to be merged strategy
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Refactor the call site of strategy.process_dataloader() from loop to data_connector
7 participants
@ninginthecloud @ananthsub @awaelchli @Borda @carmocca @krshrimali @rohitgr7