Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/n] add Stateful functionality support for Callbacks #12232

Merged
merged 10 commits into from
Mar 19, 2022
Merged

[2/n] add Stateful functionality support for Callbacks #12232

merged 10 commits into from
Mar 19, 2022

Conversation

jjenniferdai
Copy link
Contributor

@jjenniferdai jjenniferdai commented Mar 4, 2022 •
edited
Loading

What does this PR do?

Part of / Fixes #11429 : introduce Stateful Callbacks
part 2. of the full implementation PR reference

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@jjenniferdai jjenniferdai marked this pull request as ready for review March 4, 2022 19:05
@ananthsub ananthsub added callback checkpointing Related to checkpointing labels Mar 4, 2022
@ananthsub ananthsub added this to the 1.6 milestone Mar 4, 2022
@awaelchli awaelchli mentioned this pull request Mar 4, 2022
Closed
@mergify mergify bot added the has conflicts label Mar 9, 2022
@mergify mergify bot removed the has conflicts label Mar 9, 2022
awaelchli
awaelchli reviewed Mar 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tests/callbacks/test_callbacks.py Show resolved Hide resolved
pytorch_lightning/trainer/connectors/checkpoint_connector.py Show resolved Hide resolved
@jjenniferdai @awaelchli
Update CHANGELOG.md
64ebfcf 
Co-authored-by: Adrian Wälchli <[email protected]>
@awaelchli awaelchli enabled auto-merge (squash) March 12, 2022 01:43
@mergify mergify bot added the ready PRs ready to be merged label Mar 12, 2022
Borda
Borda reviewed Mar 14, 2022
View reviewed changes
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
auto-merge was automatically disabled March 14, 2022 17:11

Head branch was pushed to by a user without write access

@jjenniferdai jjenniferdai requested a review from Borda March 14, 2022 17:16
tchaton
tchaton approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) March 16, 2022 02:07
@jjenniferdai jjenniferdai mentioned this pull request Mar 16, 2022
Merged
12 tasks
@mergify mergify bot removed the has conflicts label Mar 19, 2022
@tchaton tchaton merged commit 6ba6678 into Lightning-AI:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellepintz daniellepintz daniellepintz left review comments

@ananthsub ananthsub ananthsub approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees
No one assigned
Labels
callback checkpointing Related to checkpointing ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Standardize all stateful components on state_dict/load_state_dict
6 participants
@jjenniferdai @ananthsub @awaelchli @Borda @tchaton @daniellepintz