Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent last checkpoint being deleted after resumed training with changed dirpath #12225

Merged
merged 23 commits into from
Mar 28, 2022

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Mar 4, 2022

What does this PR do?

Fixes #11379. Also addresses #12045 (comment).

Does your PR introduce any breaking changes? If yes, please list them.

Yes, if the checkpoint's dirpath has changed on resumed training, last_model_path won't be reloaded. In the PR before (#12045), we stopped reloading best_model_score, kth_best_model_path, kth_value, best_k_models.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @awaelchli @ninginthecloud @jjenniferdai @rohitgr7

@krshrimali krshrimali added callback: model checkpoint feature Is an improvement or enhancement breaking change Includes a breaking change labels Mar 4, 2022
@krshrimali krshrimali added this to the 1.6 milestone Mar 4, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 22, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Mar 24, 2022
@krshrimali
Copy link
Contributor Author

Reviews: will fix merge conflicts in an hour, and hopefully we can merge then if all is good. :)

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 28, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) March 28, 2022 15:09
@rohitgr7 rohitgr7 merged commit 97121a5 into master Mar 28, 2022
@rohitgr7 rohitgr7 deleted the checkpoint/last_model_path branch March 28, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change callback: model checkpoint feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resuming training with ModelCheckpoint can delete checkpoints in other runs
4 participants