-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent last checkpoint being deleted after resumed training with changed dirpath
#12225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krshrimali
requested review from
williamFalcon,
tchaton,
carmocca,
Borda,
kaushikb11,
SeanNaren,
awaelchli,
justusschock and
rohitgr7
as code owners
March 4, 2022 11:04
krshrimali
added
callback: model checkpoint
feature
Is an improvement or enhancement
breaking change
Includes a breaking change
labels
Mar 4, 2022
krshrimali
commented
Mar 4, 2022
carmocca
reviewed
Mar 5, 2022
…ing/pytorch-lightning into checkpoint/last_model_path
for more information, see https://pre-commit.ci
…ing/pytorch-lightning into checkpoint/last_model_path
for more information, see https://pre-commit.ci
krshrimali
commented
Mar 7, 2022
krshrimali
commented
Mar 7, 2022
carmocca
reviewed
Mar 21, 2022
carmocca
approved these changes
Mar 21, 2022
rohitgr7
reviewed
Mar 22, 2022
carmocca
reviewed
Mar 22, 2022
rohitgr7
approved these changes
Mar 22, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
Borda
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reviews: will fix merge conflicts in an hour, and hopefully we can merge then if all is good. :) |
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
callback: model checkpoint
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11379. Also addresses #12045 (comment).
Does your PR introduce any breaking changes? If yes, please list them.
Yes, if the checkpoint's
dirpath
has changed on resumed training,last_model_path
won't be reloaded. In the PR before (#12045), we stopped reloadingbest_model_score, kth_best_model_path, kth_value, best_k_models
.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @carmocca @awaelchli @ninginthecloud @jjenniferdai @rohitgr7