Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returning logged metrics instead of callback metrics during evaluation #12224

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Mar 4, 2022

What does this PR do?

With

self.log(..., on_step=True, on_epoch=True

the results returned were:

valid_loss3.0            │
│     valid_loss_epoch3.0            │
└───────────────────────────┴──────────────────────────

should be just logged metrics instead.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@rohitgr7 rohitgr7 added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Mar 4, 2022
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Mar 4, 2022
@rohitgr7 rohitgr7 changed the title Fix returning callback metrics instead of logged metrics during evaluation Fix returning logged metrics instead of callback metrics during evaluation Mar 4, 2022
@Borda Borda modified the milestones: 1.5.x, 1.6 Mar 21, 2022
@rohitgr7 rohitgr7 self-assigned this Mar 21, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 23, 2022
@tchaton tchaton enabled auto-merge (squash) March 23, 2022 12:16
@mergify mergify bot added the ready PRs ready to be merged label Mar 23, 2022
@tchaton tchaton merged commit c822a6a into master Mar 23, 2022
@tchaton tchaton deleted the fix/eval_log branch March 23, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants