Replaced eval() with ast.literal_eval() for secure conversions #12212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR fixes a security vulnerability which allows for executing arbitrary code on the target system in the context of the user running the program. The attacker can execute commands on the target OS running the operating system by setting the
PL_TRAINER_GPUS
when using theTrainer
module.Before:
pytorch_lightning/utilities/argeparse.py
at Line 124Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
PS: This vulnerability was first disclosed on
huntr.dev