Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced eval() with ast.literal_eval() for secure conversions #12212

Merged
merged 4 commits into from
Mar 5, 2022
Merged

Replaced eval() with ast.literal_eval() for secure conversions #12212

merged 4 commits into from
Mar 5, 2022

Conversation

whokilleddb
Copy link
Contributor

What does this PR do?

The PR fixes a security vulnerability which allows for executing arbitrary code on the target system in the context of the user running the program. The attacker can execute commands on the target OS running the operating system by setting the PL_TRAINER_GPUS when using the Trainer module.

Before:

  • In pytorch_lightning/utilities/argeparse.py at Line 124
        if not (val is None or val == ""):
            # todo: specify the possible exception
            with suppress(Exception):
                # converting to native types like int/float/bool
                val = eval(val)
  • After:
        if not (val is None or val == ""):
            # todo: specify the possible exception
            with suppress(Exception):
                # converting to native types like int/float/bool
                val = literal_eval(val)
            env_args[arg_name] = val

Before submitting

  • [x ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [ x] Did you read the contributor guideline, Pull Request section?
  • [ x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ x] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [ x] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

PS: This vulnerability was first disclosed on huntr.dev

@ananthsub ananthsub added this to the 1.5.x milestone Mar 3, 2022
@ananthsub ananthsub added bug Something isn't working trainer: argument labels Mar 3, 2022
@whokilleddb
Copy link
Contributor Author

Hi @carmocca, as per our discussion on huntr.dev, can you please review the fix and mark the fix on huntr.dev accordingly? Thank You 😃

@mergify mergify bot added the ready PRs ready to be merged label Mar 3, 2022
@carmocca
Copy link
Contributor

carmocca commented Mar 3, 2022

Will do! Just needs to be merged first.

@carmocca carmocca enabled auto-merge (squash) March 4, 2022 01:36
@whokilleddb whokilleddb requested a review from carmocca March 4, 2022 05:57
@carmocca carmocca merged commit 8b7a12c into Lightning-AI:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged trainer: argument
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants