Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PyTorch 1.7 testing from the CI #12191

Merged
merged 17 commits into from
Mar 8, 2022
Merged

Drop PyTorch 1.7 testing from the CI #12191

merged 17 commits into from
Mar 8, 2022

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Mar 2, 2022 •
edited by github-actions bot
Loading

What does this PR do?

For preparing the upcoming release, we plan to drop PyTorch 1.7 testing from the CI. Partially fixes #12161.

Does your PR introduce any breaking changes? If yes, please list them.

Waiting for the CI to turn green.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @akihironitta @carmocca @Borda

@krshrimali krshrimali added the ci Continuous Integration label Mar 2, 2022
@krshrimali krshrimali added this to the 1.6 milestone Mar 2, 2022
carmocca
carmocca reviewed Mar 2, 2022
View reviewed changes
.github/workflows/ci_test-full.yml Outdated Show resolved Hide resolved
.github/workflows/ci_dockers.yml Show resolved Hide resolved
@carmocca
Copy link
Contributor

carmocca commented Mar 2, 2022

We need to update this too: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.azure-pipelines/ipu-tests.yml#L16 to install PopTorch 2.2.

@Borda Do you know where to find the sdk download?

akihironitta
akihironitta reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI section in README.md needs updating, too.

krshrimali
krshrimali commented Mar 4, 2022
View reviewed changes
Copy link
Contributor Author

@krshrimali krshrimali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horovod installation is failing. Debugging what went wrong. It's failing in master as well, so
probably not related to this PR. There is an issue here.

.github/workflows/ci_test-conda.yml Show resolved Hide resolved
.github/workflows/ci_dockers.yml Show resolved Hide resolved
@krshrimali krshrimali marked this pull request as draft March 4, 2022 04:18
@krshrimali
Copy link
Contributor Author

The CI section in README.md needs updating, too.

Thanks, @akihironitta! Done. https://github.com/PyTorchLightning/pytorch-lightning/blob/drop/pytorch-1.7/README.md

@krshrimali krshrimali marked this pull request as ready for review March 4, 2022 05:55
@carmocca carmocca added the priority: 0 High priority task label Mar 4, 2022
awaelchli
awaelchli approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subsequently, all markers @RunIf(min_torch="1.8") or below can be dropped from our tests, here or in follow up. Tests with @RunIf(max_torch="1.7") can be dropped entriely.

You will find more references that end up in dead code or outdated comments if you grep torch 1.7

akihironitta
akihironitta approved these changes Mar 8, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 8, 2022
@carmocca
Copy link
Contributor

carmocca commented Mar 8, 2022

@awaelchli thanks! We plan to do those in a separate PR as per the linked issue description.

Borda
Borda reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think first we need to add PT 1.11 #11792

@carmocca carmocca enabled auto-merge (squash) March 8, 2022 16:39
@carmocca carmocca disabled auto-merge March 8, 2022 18:02
@carmocca carmocca merged commit 821ca7e into master Mar 8, 2022
@carmocca carmocca deleted the drop/pytorch-1.7 branch March 8, 2022 18:02
Borda pushed a commit to jerome-habana/lightning that referenced this pull request Mar 10, 2022
@krshrimali @carmocca
@awaelchli @akihironitta @Borda
Drop PyTorch 1.7 testing from the CI (Lightning-AI#12191)
bd76456 
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Aki Nitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Drop PyTorch 1.7 support
5 participants
@krshrimali @carmocca @awaelchli @Borda @akihironitta